[SDPA-5959] coding standards fixes #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-hopper
requested review from
MdNadimHossain,
GROwen and
anthony-malkoun
christopher-hopper
force-pushed
the
feature/SDPA-5959-coding-standards-fixes
branch
from
9f68dc4 to
4950229
Compare
|
Tests failing due to a patch that will not apply. This patch is unrelated to the changes in this PR. Cannot apply patch jQuery UI Touch Punch library - https://www.drupal.org/project/jquery_ui_touch_punch/issues/3159222#comment-14011939 (https://www.drupal.org/files/issues/2021-02-26/jquery_ui_touch_punch.patch)! |
Thanks, @christopher-hopper , seems like the issue is actually fixed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Requires review and testing. These changes allow this module to pass DrupalPractice phpcs sniffs.